Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2680] Improve placement rule funtion's test coverage #895

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve placement rule funtion's test coverage

  • fixed rule
  • tag rule
  • user rule

What type of PR is it?

  • - Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2680

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (a786feb) to head (3e4a3ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   77.71%   77.95%   +0.23%     
==========================================
  Files          97       97              
  Lines       12119    12119              
==========================================
+ Hits         9418     9447      +29     
+ Misses       2378     2358      -20     
+ Partials      323      314       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in 5e3535c Jun 18, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2680 branch June 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants