Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-421] Define app gang scheduling info in API package. #200

Merged
merged 17 commits into from
Oct 27, 2020
Merged

[YUNIKORN-421] Define app gang scheduling info in API package. #200

merged 17 commits into from
Oct 27, 2020

Conversation

yangwwei
Copy link
Contributor

No description provided.

@yangwwei yangwwei self-assigned this Oct 23, 2020
Copy link
Contributor

@kingamarton kingamarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and fix the e2e tests. It seems that there are some issues with JSON unmarshalling: "error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go struct field ApplicationSpec.taskGroups of type v1alpha1.TaskGroups"

test/e2e/app/app_test.go Outdated Show resolved Hide resolved
test/e2e/testdata/application.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #200 into YUNIKORN-2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           YUNIKORN-2     #200   +/-   ##
===========================================
  Coverage       58.29%   58.29%           
===========================================
  Files              33       33           
  Lines            2928     2928           
===========================================
  Hits             1707     1707           
  Misses           1149     1149           
  Partials           72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c210676...ea9c087. Read the comment docs.

@yangwwei yangwwei merged commit 6eba8fd into apache:YUNIKORN-2 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants