Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-469]Implement recycling service in PlaceholderManager that cleans up orphan placeholders #208

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

HuangTing-Yao
Copy link
Contributor

Run a goroutine to delete orphan placeholders every 5 seconds.
Please review @yangwwei .
Thanks.

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (YUNIKORN-2@44b4069). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             YUNIKORN-2     #208   +/-   ##
=============================================
  Coverage              ?   59.25%           
=============================================
  Files                 ?       36           
  Lines                 ?     3154           
  Branches              ?        0           
=============================================
  Hits                  ?     1869           
  Misses                ?     1201           
  Partials              ?       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b4069...a854cee. Read the comment docs.

pkg/cache/placeholder_manager.go Show resolved Hide resolved
pkg/cache/placeholder_manager.go Show resolved Hide resolved
pkg/cache/placeholder_manager.go Show resolved Hide resolved
Copy link
Contributor

@yangwwei yangwwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yangwwei yangwwei merged commit 4a99330 into apache:YUNIKORN-2 Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants