Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-501] Include node-selector and tolerations in the placeholder's pod spec. #217

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

yangwwei
Copy link
Contributor

@yangwwei yangwwei commented Jan 7, 2021

No description provided.

@yangwwei yangwwei self-assigned this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #217 (4314d00) into YUNIKORN-2 (132fdae) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           YUNIKORN-2     #217      +/-   ##
==============================================
- Coverage       59.66%   59.41%   -0.25%     
==============================================
  Files              35       35              
  Lines            3131     3129       -2     
==============================================
- Hits             1868     1859       -9     
- Misses           1182     1188       +6     
- Partials           81       82       +1     
Impacted Files Coverage Δ
pkg/cache/application_events.go 53.06% <ø> (ø)
pkg/cache/placeholder_manager.go 77.27% <ø> (+3.35%) ⬆️
pkg/cache/task.go 70.40% <ø> (-4.00%) ⬇️
pkg/common/si_helper.go 63.15% <ø> (ø)
pkg/cache/placeholder.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132fdae...4314d00. Read the comment docs.

@yangwwei
Copy link
Contributor Author

Merging this to the dev branch. I will create a PR for the review before committing to the master.

@yangwwei yangwwei merged commit 396d0b1 into apache:YUNIKORN-2 Jan 14, 2021
@yangwwei yangwwei deleted the YUNIKORN-501-2 branch January 14, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant