-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1338] [admission] support different kind of workloads other than pods #467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 68.03% 68.30% +0.26%
==========================================
Files 42 42
Lines 6921 6989 +68
==========================================
+ Hits 4709 4774 +65
- Misses 2042 2044 +2
- Partials 170 171 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ad4618d
to
7524696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have given comments..
327877c
to
3859fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
Handle non-pod workloads in the admission controller.
To have a better design & readability,
usergroup.go
andusergroup_test.go
has been moved to a new package. Also, related functions are now bound to a type - they are not global anymore in the "main" package.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1338
How should this be tested?
Screenshots (if appropriate)
Questions: