[YUNIKORN-1369] Shim: Read configuration from configmaps and deprecate legacy configs #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 68.06% 69.30% +1.24%
==========================================
Files 42 42
Lines 7065 7592 +527
==========================================
+ Hits 4809 5262 +453
- Misses 2086 2153 +67
- Partials 170 177 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
craigcondit
force-pushed
the
YUNIKORN-1369
branch
3 times, most recently
from
e7e082b
to
bcee1e1
Compare
craigcondit
changed the title
craigcondit
force-pushed
the
YUNIKORN-1369
branch
from
bcee1e1
to
f63cb0d
Compare
pbacsko
reviewed
Nov 16, 2022
pbacsko
reviewed
Nov 16, 2022
| case cache.DeletedFinalStateUnknown: | ||
| configmap = utils.Convert2ConfigMap(obj) | ||
| default: | ||
| log.Logger().Debug("unable to convert to configmap") |
There was a problem hiding this comment.
I know it's an unlikely code path but I'd use an Error() or Warn() here.
There was a problem hiding this comment.
Fair point. I'll update in the next version.
pbacsko
reviewed
Nov 16, 2022
pbacsko
approved these changes
Nov 16, 2022
|
Merged to master, updated Debug() to Warn() as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Read configuration from new ConfigMap entries in addition to legacy values, and deprecate old configuration sources.
[WIP] Based on and depends on from YUNIKORN-1365.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1369
How should this be tested?
Screenshots (if appropriate)
Questions: