Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim #523

Closed
wants to merge 2 commits into from

Conversation

zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Feb 7, 2023

What is this PR for?

Before we do more changes to remove nodename noderack in node attribute, and then add noderack to nodeinfo, also change in Scheduler Interface and webapp in https://issues.apache.org/jira/browse/YUNIKORN-1560

We first fix the consistence with interface and shim, then i will do above things.

And don't change the nodelabels field, because we will address new nodelabels pass instead of the json now in another jira:
https://issues.apache.org/jira/browse/YUNIKORN-1550

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@wilfred-s
Copy link
Contributor

See the comment in YUNIKORN-1560 I don't think this is needed as it will be overwritten by that change.

@wilfred-s
Copy link
Contributor

This change is not needed, YUNIKORN-1560 will handle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants