New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1601] Shim: Implement preemption predicate handling #542
Conversation
5266fdf
to
d7c6603
Compare
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 69.56% 69.24% -0.32%
==========================================
Files 45 45
Lines 7731 7801 +70
==========================================
+ Hits 5378 5402 +24
- Misses 2156 2199 +43
- Partials 197 200 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d7c6603
to
1e8e4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need unit test for IsPodFitNodeViaPreemption()
.
Again, same as above, this would require mocking out a substantial amount of the underlying code, which doesn't really verify that it works properly. As with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questioms, concerns have been addressed.
+1 LGTM
What is this PR for?
Add PreemptionPredicates() RM callback implementation to support preemption in core.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1601
How should this be tested?
Manually verified that algorithm functions when combined with apache/yunikorn-core#511.
Basic unit tests.
Will add e2e tests once the core implementation is finalized.
Screenshots (if appropriate)
Questions: