New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1597] e2e tests: Recover assigned pods in Bound state #544
Conversation
aabe70a
to
3c6aca2
Compare
I'm -1 on this approach as it doesn't allow for running on anything but a Kind cluster. Our tests should be cluster-agnostic, and adapt to the environment they are run in so that they can be used on real clusters as well. |
Alternate approach: Query the cluster for nodes with available capacity, and construct pods with nodeAffinity specified so that they are only schedulable on those nodes. |
Yeah, most tests are agnostic, but there are some (maybe just the one which I modified) which already depends on having 3 nodes (1 control + 2 worker). Perhaps the existing tests should be fixed, too in a follow-up JIRA.
Hm, interesting. I'll try this. |
3c6dc6c
to
17d1d80
Compare
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 46 46
Lines 7881 7881
=======================================
Hits 5515 5515
Misses 2163 2163
Partials 203 203 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
17d1d80
to
883ebbf
Compare
Test failure seems to be unrelated. |
883ebbf
to
ff3ce58
Compare
1bc0299
to
d7a6c55
Compare
d7a6c55
to
dd96878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
The PR contains an e2e test which validates that YK can recover properly with Running/Pending placeholders.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1597
How should this be tested?
Screenshots (if appropriate)
Questions: