New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1273] Add configurable option to have unique application ids in a namespace #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter issues on comments, and two other minor comment nits
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 69.95% 70.18% +0.23%
==========================================
Files 47 47
Lines 7938 7950 +12
==========================================
+ Hits 5553 5580 +27
+ Misses 2177 2164 -13
+ Partials 208 206 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…s in a namespace]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
Ability to configure autogenerated application ids. Currently, if the app id is not specified, yunikorn generates the application id with the name 'yunikorn-<name_space>-autogen' and all the pods with no application id are bundled under that name. This change adds an option to have unique auto-generated names. Appends pod uid after the namespace name to make it unique.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
Successfully ran these commands in k8shim
make license-check
make lint
make test
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: