-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1826] Convert shim to use scoped logging #623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 71.01% 70.91% -0.10%
==========================================
Files 50 50
Lines 8190 8190
==========================================
- Hits 5816 5808 -8
- Misses 2170 2178 +8
Partials 204 204
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, some minor changes below.
@FrankYang0529 there are also a few merge conflicts caused by recent PRs that will need to be fixed, hopefully nothing too complex. |
Signed-off-by: Frank Yang <yangpoan@gmail.com>
8e472ce
to
6101ad2
Compare
Hi @craigcondit, thanks for the review. I updated my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Looks good. Will merge once e2e tests finish.
What is this PR for?
Convert all uses of log.Logger() to log.Log(name). This allows for fine-grained control over logging for each subsystem.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1826
How should this be tested?
No functionality is changed, only the logging method.
Screenshots (if appropriate)
Questions: