Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1826] Convert shim to use scoped logging #623

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

Convert all uses of log.Logger() to log.Log(name). This allows for fine-grained control over logging for each subsystem.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1826

How should this be tested?

No functionality is changed, only the logging method.

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #623 (6101ad2) into master (d484165) will decrease coverage by 0.10%.
The diff coverage is 50.86%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   71.01%   70.91%   -0.10%     
==========================================
  Files          50       50              
  Lines        8190     8190              
==========================================
- Hits         5816     5808       -8     
- Misses       2170     2178       +8     
  Partials      204      204              
Impacted Files Coverage Δ
pkg/admission/informers.go 89.47% <0.00%> (ø)
pkg/admission/namespace_cache.go 85.71% <0.00%> (ø)
pkg/admission/pki/certs.go 65.21% <0.00%> (ø)
pkg/admission/priority_class_cache.go 81.66% <0.00%> (ø)
pkg/admission/util.go 96.15% <0.00%> (ø)
pkg/plugin/support/framework_handle.go 22.03% <0.00%> (ø)
pkg/cache/application_state.go 90.18% <20.00%> (ø)
pkg/appmgmt/appmgmt.go 49.35% <33.33%> (ø)
pkg/cache/task_state.go 71.95% <33.33%> (ø)
pkg/cache/context_recovery.go 43.38% <36.36%> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, some minor changes below.

pkg/schedulerplugin/scheduler_plugin.go Outdated Show resolved Hide resolved
pkg/admission/pki/certs.go Outdated Show resolved Hide resolved
pkg/admission/conf/am_conf.go Outdated Show resolved Hide resolved
pkg/log/logger.go Outdated Show resolved Hide resolved
pkg/log/logger.go Outdated Show resolved Hide resolved
pkg/common/si_helper.go Outdated Show resolved Hide resolved
@craigcondit
Copy link
Contributor

@FrankYang0529 there are also a few merge conflicts caused by recent PRs that will need to be fixed, hopefully nothing too complex.

Signed-off-by: Frank Yang <yangpoan@gmail.com>
@FrankYang0529
Copy link
Member Author

Hi @craigcondit, thanks for the review. I updated my PR.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Looks good. Will merge once e2e tests finish.

@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1826 branch June 28, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants