Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1828] unify plugin.yaml with other deployment example files #678

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

steinsgateted
Copy link
Contributor

@steinsgateted steinsgateted commented Sep 16, 2023

What is this PR for?

changed items:

  • add some description: deployments/scheduler/README.md
  • deployments/scheduler/plugin.yaml remove RBAC, health check, load balancing
  • remove deployments/scheduler/scheduler-load.yaml
  • The load balance part is independent: deployments/scheduler/service.yaml

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1828

How should this be tested?

1 Install kind
2 sudo kubectl create -f yunikorn-rbac.yaml
3 sudo kubectl create configmap yunikorn-configs --from-file=yunikorn-configs.yaml
4 sudo kubectl apply -f plugin.yaml
5 check yunikorn web

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #678 (a40e119) into master (5fe1b95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   71.92%   71.92%           
=======================================
  Files          51       51           
  Lines        8082     8082           
=======================================
  Hits         5813     5813           
  Misses       2073     2073           
  Partials      196      196           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@steinsgateted steinsgateted self-assigned this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant