[YUNIKORN-2189] Change the log level of "adding node to cache" from WARN to INFO #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on this. That code is in the process of being substantially refactored as part of the scheduler init work. In fact, nodes.go no longer exists in my latest draft PR. |
|
@brandboat please put this PR back to Draft. This code is being rewritten. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 69.52% 69.43% -0.09%
==========================================
Files 50 50
Lines 7993 7993
==========================================
- Hits 5557 5550 -7
- Misses 2248 2254 +6
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
|
Closing as this was addressed in the PR for YUNIKORN-2180. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
change log level
adding node to cachefrom WARN to INFO.the other logs having similar output are using INFO level.
https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/partition.go#L542
https://github.com/apache/yunikorn-k8shim/blob/master/pkg/cache/nodes.go#L103
What type of PR is it?
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2189
How should this be tested?
only change log level.
Screenshots (if appropriate)
N/A
Questions:
N/A