Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2393] Upgrade codecov/codecov-action to v4 #783

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

@chenyulin0719 chenyulin0719 commented Feb 7, 2024

What is this PR for?

Upgrade codecov/codecov-action from v3 to v4.
Support "secrets.CODECOV_TOKEN" for codecov analysis in forked repo.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2393

How should this be tested?

Trigger workflow then check codecov report in PR conversation.

Screenshots (if appropriate)

NA

Questions:

NA

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (458916f) 71.16% compared to head (c8af1a3) 71.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   71.16%   71.80%   +0.64%     
==========================================
  Files          43       43              
  Lines        7691     6313    -1378     
==========================================
- Hits         5473     4533     -940     
+ Misses       2016     1578     -438     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chia7712
Copy link
Contributor

chia7712 commented Feb 7, 2024

@chenyulin0719 Does it look good at your repo?

@chenyulin0719
Copy link
Contributor Author

@chia7712
Copy link
Contributor

chia7712 commented Feb 7, 2024

will merge it after QA

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in 5f8d20b Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants