[YUNIKORN-2456] Remove weak ciphers #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set limited ciphers on TLS connections, removing weak ciphers. Based on the list maintained in the go standard TLS library.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 71.58% 71.61% +0.03%
==========================================
Files 43 43
Lines 6338 6338
==========================================
+ Hits 4537 4539 +2
+ Misses 1599 1597 -2
Partials 202 202 ☔ View full report in Codecov by Sentry. |
chia7712
reviewed
Feb 27, 2024
| MinVersion: tls.VersionTLS12, | ||
| Certificates: []tls.Certificate{*certs}}, | ||
| MinVersion: tls.VersionTLS12, // No SSL, TLS 1.0 or TLS 1.1 support | ||
| NextProtos: []string{"h2", "http/1.1"}, // prefer HTTP/2 over HTTP/1.1 |
There was a problem hiding this comment.
Should we remove the cipher suits which may be treated as error by http/2 with tls 1.2?
see RFC 7540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Set limited ciphers on TLS connections, removing weak ciphers. Based on the list maintained in the go standard TLS library.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Standard e2e tests cover the changes