Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2558]Remove redundent conditional to install tools #819

Closed
wants to merge 1 commit into from

Conversation

SophieTech88
Copy link
Contributor

What is this PR for?

The script skips the make tools if the tools folder is existent. That is a bit weird that we don't check all tools in the folder. The script should call make tools anyway, and let make tools do the check and install.
Action: remove the conditional of install_tools function in run-e2e-tests.sh file .

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2558

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.13%. Comparing base (7557508) to head (95af7bb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   66.13%   66.13%           
=======================================
  Files          69       69           
  Lines        7517     7517           
=======================================
  Hits         4971     4971           
  Misses       2334     2334           
  Partials      212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chia7712
Copy link
Contributor

unrelated error. will merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants