[YUNIKORN-2563] [shim] Enable deadlock detection during unit tests #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbacsko
requested review from
chia7712,
wilfred-s,
craigcondit and
chenyulin0719
wilfred-s
approved these changes
Apr 22, 2024
|
I do not see any specific code to change the locking as that has been added via YUNIKORN-2539 already |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 66.15% 66.13% -0.03%
==========================================
Files 69 69
Lines 7517 7517
==========================================
- Hits 4973 4971 -2
- Misses 2333 2334 +1
- Partials 211 212 +1 ☔ View full report in Codecov by Sentry. |
|
I will merge it after looping the tests 100 times |
chia7712
pushed a commit
that referenced
this pull request
Apr 22, 2024
) Closes: #821 Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Enable deadlock detection in the Makefile for "test" target.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2563
How should this be tested?
Screenshots (if appropriate)
Questions: