[YUNIKORN-2630] Release context lock early for config changes #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release the lock of the context in the shim when processing is done. When the config changes are sent to the core the k8shim should not be locked. The context changes have been finalised at that point. The core handles its own locking and serialises config changes that come in from the k8shim.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 67.33% 67.26% -0.07%
==========================================
Files 70 70
Lines 7598 7604 +6
==========================================
- Hits 5116 5115 -1
- Misses 2271 2276 +5
- Partials 211 213 +2 ☔ View full report in Codecov by Sentry. |
chia7712
approved these changes
May 21, 2024
chia7712
pushed a commit
that referenced
this pull request
May 21, 2024
Release the lock of the context in the shim when processing is done. When the config changes are sent to the core the k8shim should not be locked. The context changes have been finalised at that point. The core handles its own locking and serialises config changes that come in from the k8shim. review: remove call through api to get config. Closes: #842 Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Release the lock of the context in the shim when processing is done. When the config changes are sent to the core the k8shim should not be locked. The context changes have been finalised at that point.
The core handles its own locking and serialises config changes that come in from the k8shim.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Current unit and e2e tests cover the changed paths