Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-1541] Fix helm upgrade when host network is enabled #125

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-1541] Fix helm upgrade when host network is enabled #125

wants to merge 1 commit into from

Conversation

krishna-birla
Copy link
Contributor

  • When the host network field is set for a deployment, the pods bind to the host port.
  • In such a case, if the new pods are scheduled on the same node as the old pods, the default rolling upgrade strategy fails as the host port is unavailable and new pods can't start, because of which old pods can't terminate.
  • Use recreate strategy in such cases, so that old pods can terminate and free up the host port for the new pods to start.

[YUNIKORN-1541] Fix helm upgrade when host network is enabled
8fb40f4 
* When the host network field is set for a deployment, the pods bind to the host port.
* In such a case, if the new pods are scheduled on the same node as the old pods,
  the default rolling upgrade strategy fails as the host port is unavailable and new pods can't start,
  because of which old pods can't terminate.
* Use recreate strategy in such cases, so that old pods can terminate and free up the host port for
  the new pods to start.
@krishna-birla krishna-birla deleted the hostNetworkFix branch January 20, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@krishna-birla