-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1222] [SI] preempt pods based on the priorities #67
Conversation
@manirajv06 please regenerate the SI code (run |
scheduler-interface-spec.md
Outdated
@@ -447,6 +447,8 @@ message AllocationAsk { | |||
// Is this a placeholder ask (true) or a real ask (false), defaults to false | |||
// ignored if the taskGroupName is not set | |||
bool placeholder = 10; | |||
// Does this ask originates the application? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar: should be Is this ask the originator of the application?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing two files in the commit: si.proto
and lib/go/common/constants.go
Re-run make
to generate the files
added those two files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
SI changes for https://issues.apache.org/jira/browse/YUNIKORN-1184
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1222
How should this be tested?
Screenshots (if appropriate)
Questions: