[YUNIKORN-1460] PreemptionPolicy support #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcondit
requested changes
Dec 8, 2022
scheduler-interface-spec.md
Outdated
|
|
||
| ```protobuf | ||
| message PreemptionPolicy { | ||
| // Allow preemption while running |
There was a problem hiding this comment.
Can we rename these, and remove Kubernetes-specific terminology?
Maybe allowPreemptSelf, allowPreemptOther (both boolean)
There was a problem hiding this comment.
We should remove the comments referring to Kubernetes. These should simply describe their purpose, nothing more (i.e. "whether task can preempt lower-priority tasks" and "whether task can be preempted by higher-priority tasks") or something.
pbacsko
force-pushed
the
YUNIKORN-1460
branch
3 times, most recently
from
37d4d46
to
8ca90d8
Compare
pbacsko
force-pushed
the
YUNIKORN-1460
branch
from
8ca90d8
to
807a0d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add a new
PreemptionPolicyobject and updateAllocationAskwith it.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1460
How should this be tested?
Screenshots (if appropriate)
Questions: