[YUNIKORN-2471] Documentation update for max 0 queue resources. #423
Conversation
Signed-off-by: tommyfufu <tommy860925@gmail.com>
| @@ -395,6 +395,7 @@ There is no guaranteed resource setting for the root queue. | |||
|
|
|||
| Maximum resources when configured place a hard limit on the size of all allocations that can be assigned to a queue at any point in time. | |||
| A maximum resource can be set to 0 which makes the resource not available to the queue. | |||
There was a problem hiding this comment.
change from:
A maximum resource can be set to 0 which makes the resource not available to the queue.
to:
A single resource type within the maximum resource can be set to 0 which makes that type not available to the queue.
| @@ -395,6 +395,7 @@ There is no guaranteed resource setting for the root queue. | |||
|
|
|||
| Maximum resources when configured place a hard limit on the size of all allocations that can be assigned to a queue at any point in time. | |||
| A maximum resource can be set to 0 which makes the resource not available to the queue. | |||
| However, setting all maximum resources to zero will be ignored and logged for debugging. | |||
There was a problem hiding this comment.
Change from:
However, setting all maximum resources to zero will be ignored and logged for debugging.
to:
However, a maximum resource with all resource types set to 0 will be ignored, not set on the queue, and logged for debugging.
There was a problem hiding this comment.
I just noticed that setting all the maximum resource to 0 does not simply get ignored.
If a maximum resource setting already exists in the queue, the previous setting will be cleared.
This behavior is not documented too.
There was a problem hiding this comment.
ah yes that is correct, that was introduced via YUNIKORN-2169 to allow removing a quota. if the queue is configured and no longer has a quota.
Good catch. We need to add that behaviour as it was a fix requested but never documented.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
What type of PR is it?
Todos
What is the Jira issue?
[YUNIKORN-2] Gang scheduling interface parametersHow should this be tested?
Screenshots (if appropriate)
Questions: