[YUNIKORN-1873] Web: Use standard build conventions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcondit
force-pushed
the
YUNIKORN-1873
branch
from
3caa764
to
6ee2ad0
Compare
- Allow go compiler to be overridden by GO variable - Allow Docker image name to be customized via WEB_TAG variable - Use "build" for build artifacts instead of "bin" - Install build tools to "tools" dir - Use proper Makefile dependencies - Add "distclean" target to clean up fully
craigcondit
force-pushed
the
YUNIKORN-1873
branch
from
6ee2ad0
to
aa81e39
Compare
craigcondit
requested review from
wilfred-s,
manirajv06,
sunilgovind and
pbacsko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1873
How should this be tested?
Screenshots (if appropriate)
Questions: