Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2506] fix deprecation warning for fontsource-roboto #185

Closed
wants to merge 1 commit into from

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Apr 8, 2024

What is this PR for?

migrate to @fontsource/roboto since the original fontsource-roboto is deprecated.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

YUNIKORN-2506

How should this be tested?

make
make start-dev

@chenyulin0719
Copy link
Contributor

I can't see the deprecation warning after run 'make' in yunikorn/master branch. Did you successfully reproduce the warning?

@ryankert01
Copy link
Contributor Author

@chenyulin0719 Not yet, but referring to fontsource-roboto, it's best to migrate to @fontsource/roboto since it's depracation.

@chenyulin0719
Copy link
Contributor

A small suggestion, I recommand that you can create PR from your forked branch so that we can easily checkout to your branch and validate it.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, I have no doubt about removing the deprecated package.

@wilfred-s Just for my curiosity, if you don't mind, could you let us know how to reproduce the deprecated warning.

@chenyulin0719
Copy link
Contributor

Btw, there is no 'pnpm serve' command defined in package.json. I ran the test through 'make start-dev'.

@ryankert01
Copy link
Contributor Author

Btw, there is no 'pnpm serve' command defined in package.json. I ran the test through 'make start-dev'.

That's true, my bad. Updated the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants