[YUNIKORN-1133] Upgrade angular framework to latest stable release #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilpb001
requested review from
craigcondit,
manirajv06,
wilfred-s and
sunilgovind
craigcondit
requested changes
Apr 13, 2022
There was a problem hiding this comment.
This breaks YUNIKORN-1175. Please ensure those changes are included here as well. Utilized is returned by the REST API as a collection of items keyed by resource with the percentage (0-100) as values, NOT as a single value as expressed in the json-db.json file. The second commit to that file was incorrect as the original values match what the REST API returns.
craigcondit
reviewed
Apr 13, 2022
| "memory": 0, | ||
| "vcore": 0 | ||
| }, | ||
| "utilized": 0, |
There was a problem hiding this comment.
This is incorrect -- the previous values are in the correct format:
"utilized": { "memory": 0, "vcore": 0 }
wilfred-s
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Updates Angular and related dependencies to latest releases.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1133
How should this be tested?
Screenshots (if appropriate)
Questions: