Use LOG.error(msg, e)

apache · Jun 1, 2016 · ab4a0f8 · ab4a0f8
1 parent cedf8f5
commit ab4a0f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/user/Credentials.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/user/Credentials.java
@@ -90,7 +90,7 @@ private void loadFromFile() {
       CredentialsInfoSaving info = gson.fromJson(json, CredentialsInfoSaving.class);
       this.credentialsMap = info.credentialsMap;
     } catch (IOException e) {
-      LOG.error("Error loading credentials file");
+      LOG.error("Error loading credentials file", e);
       e.printStackTrace();
     }
   }
@@ -114,9 +114,8 @@ private void saveToFile() throws IOException {
       out.append(jsonString);
       out.close();
       fos.close();
-    } catch  (IOException e) {
-      LOG.error("Error saving credentials file");
-      e.printStackTrace();
+    } catch (IOException e) {
+      LOG.error("Error saving credentials file", e);
     }
   }
 

diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java
@@ -49,8 +49,7 @@ public NotebookAuthorization(ZeppelinConfiguration conf) {
     try {
       loadFromFile();
     } catch (IOException e) {
-      LOG.error("Error loading NotebookAuthorization");
-      e.printStackTrace();
+      LOG.error("Error loading NotebookAuthorization", e);
     }
   }