-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for? This is to make view of revisions non-editable ### What type of PR is it? Improvement ### Todos * [x] - disable action bar buttons * [x] - disable per paragraph editing actions * [x] - disable hotkeys ### What is the Jira issue? [ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745) ### How should this be tested? 1. initialize `GitNotebookRepo` by adding ``` export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo" ``` in your `conf/zeppelin-env.sh` 2. go to any note and create few revisions using commit menu 3. then switch between revisions, during which you shouldn't be able to modify note ### Screenshots (if appropriate) ![revision_view](https://cloud.githubusercontent.com/assets/1642088/21340828/53131054-c6cc-11e6-960b-abf5db905194.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closes #1775 from khalidhuseynov/feat/revision-view and squashes the following commits: 59a92ea [Khalid Huseynov] Merge branch 'master' into feat/revision-view bbaf286 [Khalid Huseynov] initialize looknfeel efe09c0 [Khalid Huseynov] enable report view without save b3a78c7 [Khalid Huseynov] dont show bingings, perms, hotkeys 843abf4 [Khalid Huseynov] remove escaped single quote inside console 84d2c5a [Khalid Huseynov] disable personalized mode button fa05bdb [Khalid Huseynov] Merge branch 'master' into feat/revision-view 1a5a6a7 [Khalid Huseynov] render result change without commit 06e2977 [Khalid Huseynov] check newValue for undefined 2823142 [Khalid Huseynov] add group span for ng-if 4bfe560 [Khalid Huseynov] gray out editor on revision view e9d3ceb [Khalid Huseynov] disable edit on db click md interpreter aff02b9 [Khalid Huseynov] don't show paragraph level hide output buttton 1eea8ce [Khalid Huseynov] don't show paragraph level hide editor button 46d67af [Khalid Huseynov] disable show/hide output in note action bar 0946377 [Khalid Huseynov] disable show/hide code in note action-bar 81346e9 [Khalid Huseynov] disable editing note name 7751b69 [Khalid Huseynov] disable hotkeys 9b85e05 [Khalid Huseynov] disable editor editing 00fb556 [Khalid Huseynov] make paragraph title non-editable c55de95 [Khalid Huseynov] don't show run/cancel on paragraph 19cacbd [Khalid Huseynov] don't show paragraph settings menu 7d115b8 [Khalid Huseynov] disable + new paragraph 711c0b3 [Khalid Huseynov] disable scheduler ab8ab4d [Khalid Huseynov] disable remove note 5d9f877 [Khalid Huseynov] disable revision commit 50d40ad [Khalid Huseynov] disable export note 46238e8 [Khalid Huseynov] disable clone note 8e97800 [Khalid Huseynov] disable clear output fa1397d [Khalid Huseynov] disable run all 4c83895 [Khalid Huseynov] change var name revisionDisabled -> revisionView
- Loading branch information
1 parent
70d4ad3
commit d9a11a9
Showing
9 changed files
with
184 additions
and
135 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.