Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX][ZEPPELIN-1169] Fix wrong Guava version #1199

Closed
wants to merge 1 commit into from

Conversation

jongyoul
Copy link
Member

What is this PR for?

Fixing the incompatible version for guava

What type of PR is it?

[Hot Fix]

Todos

  • - Revert guava.version for fitting in hadoop-2.6

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1169

How should this be tested?

  1. mvn clean package -Pspark-1.6 -Phadoop-2.4 -Pyarn -Ppyspark -DskipTests
  2. Run spark interpreter with simple script

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member Author

@Leemoonsoo I've reverted guava version for original one.

@jongyoul
Copy link
Member Author

At first, revert the version and will find how to do selenium test via Safari.

@jongyoul jongyoul changed the title ZEPPELIN-1169 Fix wrong Guava version [HOTFIX][ZEPPELIN-1169] Fix wrong Guava version Jul 18, 2016
@jongyoul jongyoul closed this Jul 18, 2016
@jongyoul jongyoul reopened this Jul 18, 2016
@jongyoul jongyoul closed this Jul 19, 2016
@jongyoul jongyoul reopened this Jul 19, 2016
@jongyoul jongyoul closed this Jul 19, 2016
@jongyoul jongyoul reopened this Jul 19, 2016
@bzz
Copy link
Member

bzz commented Jul 20, 2016

Looks good to me. CI is green now.
BTW what was the reason it was changed in the first place?

AFAIK it's not possible to use Selenium with Safari that easy as it requires signed browser extension. Firefox 31 should work well though.

@jongyoul
Copy link
Member Author

@bzz I've installed Safari driver for selenium 2.48.2 which is the same version that Zeppelin uses it. But it's deprecated now and I'll try to do it with Firefox 31.

@asfgit asfgit closed this in 9d4550a Jul 20, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
Fixing the incompatible version for guava

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Revert guava.version for fitting in hadoop-2.6

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1169

### How should this be tested?
1. `mvn clean package -Pspark-1.6 -Phadoop-2.4 -Pyarn -Ppyspark -DskipTests`
1. Run spark interpreter with simple script

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes apache#1199 from jongyoul/ZEPPELIN-1169 and squashes the following commits:

e0b11c1 [Jongyoul Lee] Reverted guava.version for fitting in hadoop-2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants