Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-1199. Need to login using keytab and principal before creating SparkContext in secured cluster #1206

Closed
wants to merge 2 commits into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jul 20, 2016

What is this PR for?

Need to login using keytab and principal before creating SparkContext in secured cluster.

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

Manually verified in a secured cluster.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@zjffdu
Copy link
Contributor Author

zjffdu commented Jul 20, 2016

Might need to check whether it works in pyspark/sparkr.

@zjffdu zjffdu changed the title ZEPPELIN-1215. Need to login using keytab and principal before creating SparkContext in secured cluster ZEPPELIN-1199. Need to login using keytab and principal before creating SparkContext in secured cluster Jul 20, 2016
@zjffdu
Copy link
Contributor Author

zjffdu commented Jul 20, 2016

pyspark and sprakr both create SparkContext, so this fix also works in pyspark & sparkr

@@ -337,6 +339,15 @@ public SparkContext createSparkContext() {
conf.set("spark.yarn.isPython", "true");
}

if (conf.contains("spark.yarn.keytab") && conf.contains("spark.yarn.principal")) {
try {
String keytab = conf.get("spark.yarn.keytab");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we logging on with spark keytab instead of zeppelin keytab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not zeppelin keytab. It is just keytab specified by zeppelin. Every interpreter has its own setting, and this is just one of the setting.

@prabhjyotsingh
Copy link
Contributor

@zjffdu can you resolve conflict ?

@zjffdu
Copy link
Contributor Author

zjffdu commented Jul 27, 2016

@prabhjyotsingh Conflicts resolved.

@prabhjyotsingh
Copy link
Contributor

LGTM

@zjffdu
Copy link
Contributor Author

zjffdu commented Jul 28, 2016

Close it and merge it to #1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants