Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-1364: Return only the ran paragraph details for indiviual paragraph run. #1357

Closed
wants to merge 3 commits into from

Conversation

vipul1409
Copy link

@vipul1409 vipul1409 commented Aug 24, 2016

What is this PR for?

If you run a note book having lots of paragraphs and few images and svgs. Every paragraph run sends the complete notebook instead of sending the details of just the executed paragraph. We can see good performance gain if we send only the details of ran paragraph.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1364

How should this be tested?

Create a notebook with few large images etc. so that note.json size is around 4 MB.
Run %sh ls as one paragraph.
Time take for paragraph to move to pending and finished status will be very high, as the complete note will be sent for each step. If we add this fix the status changes are very fast and smooth.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No

@echarles
Copy link
Member

Didn't try the changes but definitively +1 for this to enhance performance (tried to imagine side effects but didn't find any atm)

@bzz
Copy link
Member

bzz commented Aug 26, 2016

@vipul1409 thank you, it sounds interesting! Could you please let know, if it is ready for review?

@Leemoonsoo @corneadoug do you guys see any downsides\side-effects for such change?

Seems like CI is failing for some reason, could you please check it? Usually posting the reason of CI failure speeds up the review process a lot.

@vipul1409
Copy link
Author

Yes It is ready for review.
The reason for CI failure looks unrelated to my changes as the build is failing in npm side and I have not made any JS changes.
The build is passing for few profiles and failing for few looks intermittent.
This is the error.

[ERROR] npm ERR! Callback called more than once.
[ERROR] npm ERR!

Any suggestion?

@corneadoug
Copy link
Contributor

@vipul1409 Can you rebase this PR?
I will run a few tests to see if all the paragraph updates are handled here.

@vipul1409 vipul1409 closed this Mar 7, 2017
@vipul1409
Copy link
Author

Not needed any more.

@vipul1409 vipul1409 deleted the ZEPPELIN-1364 branch March 7, 2017 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants