ZEPPELIN-1374. Should prevent use dot in interpreter name #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might also want to make sure that the Websocket API and basic API (if one exist), also check the name accordingly |
|
@corneadoug make sense, I will update the PR |
|
In backend side, it might be OK. |
|
LGTM |
|
Merge into master if there is no other comments |
asfgit
pushed a commit
that referenced
this pull request
Sep 2, 2016
dot is invalid for interpreter name as it is used as the separator of interpreter group name and interpreter name. [Improvement] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-1374 Tested it manually as shown in the screenshot.  * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #1365 from zjffdu/ZEPPELIN-1374 and squashes the following commits: d36d437 [Jeff Zhang] add rest api checking 0620c6a [Jeff Zhang] ZEPPELIN-1374. Should prevent use dot in interpreter name (cherry picked from commit 33ddc00) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: zeppelin-web/src/app/interpreter/interpreter.controller.js zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
asfgit
pushed a commit
that referenced
this pull request
Sep 2, 2016
dot is invalid for interpreter name as it is used as the separator of interpreter group name and interpreter name. [Improvement] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-1374 Tested it manually as shown in the screenshot.  * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #1365 from zjffdu/ZEPPELIN-1374 and squashes the following commits: d36d437 [Jeff Zhang] add rest api checking 0620c6a [Jeff Zhang] ZEPPELIN-1374. Should prevent use dot in interpreter name (cherry picked from commit 33ddc00) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: zeppelin-web/src/app/interpreter/interpreter.controller.js zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
| @@ -325,6 +325,15 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', | |||
| return; | |||
| } | |||
|
|
|||
| if (!$scope.newInterpreterSetting.name.indexOf('.') >= 0) { | |||
There was a problem hiding this comment.
hi, maybe this is a bug.
if ($scope.newInterpreterSetting.name.indexOf('.') >= 0) {
There was a problem hiding this comment.
Thanks @ColZer, this is a bug, maybe I introduce this when rebasing.
asfgit
pushed a commit
that referenced
this pull request
Sep 5, 2016
### What is this PR for? This is for fixing bug introduced in #1365. I may introduce this when rebasing the PR. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1374] ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #1403 from zjffdu/HotFix_ZEPPELIN-1374 and squashes the following commits: 032bafa [Jeff Zhang] HotFix for ZEPPELIN-1374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
dot is invalid for interpreter name as it is used as the separator of interpreter group name and interpreter name.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Tested it manually as shown in the screenshot.
Screenshots (if appropriate)
Questions: