Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-pages][ZEPPELIN-990] Add header anchor to gh-pages branch #1418

Closed
wants to merge 3 commits into from

Conversation

AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Sep 9, 2016

What is this PR for?

I applied header anchor to Zeppelin's docs website with #995 . It'll be good if gh-pages also has this header anchor.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-990

How should this be tested?

Run this branch locally as described in here and hover the mouse over any titles.

Screenshots (if appropriate)

anchor

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo
Copy link
Member

Tested, When i anchor click the link, that goes under the menubar. I think that need to be adjusted.

@AhyoungRyu
Copy link
Contributor Author

AhyoungRyu commented Sep 10, 2016

@Leemoonsoo Yeah didn't noticed that. Thanks! Could you check the latest change out again? :D
scroll

@Leemoonsoo
Copy link
Member

Tested and LGTM

@Leemoonsoo
Copy link
Member

Merge if there're no further discussions.

@asfgit asfgit closed this in 4280cba Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants