Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Rearrange the contents in "About Zeppelin" #1461

Closed
wants to merge 3 commits into from

Conversation

AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Sep 27, 2016

What is this PR for?

Just rearranged the placement of Zeppelin logo, title and text in "About Zeppelin". In the mobile screen as well.

What type of PR is it?

Improvement

What is the Jira issue?

No Jira issue for this

How should this be tested?

To check this change in your local, build only zeppelin-web with ./grunt build and then browse with ./grunt serve.

Screenshots (if appropriate)

  • Before
    1. desktop & tablet screen
    2. mobile screen
  • After
    1. desktop & tablet screen
    2. mobile screen

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@felixcheung
Copy link
Member

felixcheung commented Sep 27, 2016

would Patua One font be not available on some platforms/browsers?

@AhyoungRyu
Copy link
Contributor Author

@felixcheung AFAIK since this Patua One is from here, if some browser/platform can't recognize this font, it means that browser/platform users can't see any "Apache Zeppelin" logo written with Patua One.
Then they can't see this one as well. Do we need to cover this case?
screen shot 2016-09-28 at 9 22 25 am

@felixcheung
Copy link
Member

Hmmm I don't think anyone has reported this being an issue so I think we are good.
LGTM

@AhyoungRyu AhyoungRyu closed this Sep 29, 2016
@AhyoungRyu AhyoungRyu reopened this Sep 29, 2016
@AhyoungRyu
Copy link
Contributor Author

One CI test is failed in SCALA_VER="2.11" SPARK_VER="2.0.0" HADOOP_VER="2.3" PROFILE="-Pspark-2.0 -Phadoop-2.3 -Ppyspark -Psparkr -Pscalding -Pexamples -Pscala-2.11" like below

�[36mTests: succeeded 17, failed 1, canceled 0, ignored 0, pending 0�[0m
�[31m*** 1 TEST FAILED ***�[0m
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Zeppelin ........................................... SUCCESS [ 28.461 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 30.071 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 11.502 s]
[INFO] Zeppelin: Display system apis ...................... FAILURE [ 20.268 s]
[INFO] Zeppelin: Spark dependencies ....................... SKIPPED
[INFO] Zeppelin: Spark .................................... SKIPPED
[INFO] Zeppelin: Markdown interpreter ..................... SKIPPED
[INFO] Zeppelin: Angular interpreter ...................... SKIPPED
[INFO] Zeppelin: Shell interpreter ........................ SKIPPED
[INFO] Zeppelin: Livy interpreter ......................... SKIPPED
[INFO] Zeppelin: HBase interpreter ........................ SKIPPED
[INFO] Zeppelin: PostgreSQL interpreter ................... SKIPPED
[INFO] Zeppelin: JDBC interpreter ......................... SKIPPED
[INFO] Zeppelin: File System Interpreters ................. SKIPPED
[INFO] Zeppelin: Flink .................................... SKIPPED
[INFO] Zeppelin: Apache Ignite interpreter ................ SKIPPED
[INFO] Zeppelin: Kylin interpreter ........................ SKIPPED
[INFO] Zeppelin: Python interpreter ....................... SKIPPED
[INFO] Zeppelin: Lens interpreter ......................... SKIPPED
[INFO] Zeppelin: Apache Cassandra interpreter ............. SKIPPED
[INFO] Zeppelin: Elasticsearch interpreter ................ SKIPPED
[INFO] Zeppelin: BigQuery interpreter ..................... SKIPPED
[INFO] Zeppelin: Alluxio interpreter ...................... SKIPPED
[INFO] Zeppelin: web Application .......................... SKIPPED
[INFO] Zeppelin: Server ................................... SKIPPED
[INFO] Zeppelin: Packaging distribution ................... SKIPPED
[INFO] Zeppelin: Scalding interpreter ..................... SKIPPED
[INFO] Zeppelin: Examples ................................. SKIPPED
[INFO] Zeppelin: Example application - Clock .............. SKIPPED
[INFO] Zeppelin: Example application - Horizontal Bar chart SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:32 min
[INFO] Finished at: 2016-09-29T07:00:40+00:00
[INFO] Final Memory: 48M/469M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.scalatest:scalatest-maven-plugin:1.0:test (test) on project zeppelin-display_2.11: There are test failures -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :zeppelin-display_2.11

and seems irrelevant with this change.

@corneadoug
Copy link
Contributor

@AhyoungRyu Tested, LGTM!

@AhyoungRyu
Copy link
Contributor Author

@corneadoug Thanks! I retriggered CI just for sure. After checking CI then will merge this :)

@corneadoug
Copy link
Contributor

@AhyoungRyu Rebasing from master should fix the CI issue

@AhyoungRyu AhyoungRyu closed this Oct 6, 2016
@AhyoungRyu AhyoungRyu reopened this Oct 6, 2016
@AhyoungRyu
Copy link
Contributor Author

@corneadoug rebased but it still failed in Selenium test. The error log is like below

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 76.542 sec - in org.apache.zeppelin.integration.SparkParagraphIT

Results :

Failed tests: 
  ParagraphActionsIT.testWidth:314 New Width is : 4
Expected: <true>
     but: was <false>
  ParagraphActionsIT.testWidth:314 New Width is : 8
Expected: <true>
     but: was <false>

Tests in error: 
  ZeppelinIT.testSparkInterpreterDependencyLoading:234->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 » Timeout

Tests run: 16, Failures: 2, Errors: 1, Skipped: 0

[INFO] 
[INFO] --- scalatest-maven-plugin:1.0:test (test) @ zeppelin-server ---
�[36mDiscovery starting.�[0m
Oct 06, 2016 8:09:31 AM org.openqa.selenium.safari.SafariDriverServer start
INFO: Server started on port 13724
Oct 06, 2016 8:09:31 AM org.openqa.selenium.safari.SafariDriverCommandExecutor stop
INFO: Shutting down
Oct 06, 2016 8:09:31 AM org.openqa.selenium.safari.SafariDriverCommandExecutor stop
INFO: Stopping server
Oct 06, 2016 8:09:31 AM org.openqa.selenium.safari.SafariDriverServer stop
INFO: Stopping server
Oct 06, 2016 8:09:31 AM org.openqa.selenium.safari.SafariDriverCommandExecutor stop
INFO: Shutdown complete
�[36mDiscovery completed in 4 seconds, 967 milliseconds.�[0m
�[36mRun starting. Expected test count is: 1�[0m
Zeppelin is already running
�[32mWelcomePageSuite:�[0m
�[32m- Welcome sign is correct�[0m
Zeppelin stop �[60G[�[1;32m  OK  �[0;39m]
�[36mRun completed in 13 seconds, 782 milliseconds.�[0m
�[36mTotal number of tests run: 1�[0m
�[36mSuites: completed 3, aborted 0�[0m
�[36mTests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0�[0m
�[32mAll tests passed.�[0m
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (stop-zeppelin) @ zeppelin-server ---
[INFO] Executing tasks

main:
     [exec] Zeppelin is not running
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-failsafe-plugin:2.16:verify (default) @ zeppelin-server ---
[INFO] Failsafe report directory: /home/travis/build/apache/zeppelin/zeppelin-server/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 12.285 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [  6.291 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [  3.479 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 37.316 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [  6.898 s]
[INFO] Zeppelin: Server ................................... FAILURE [09:22 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:29 min
[INFO] Finished at: 2016-10-06T08:09:45+00:00
[INFO] Final Memory: 46M/376M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:verify (default) on project zeppelin-server: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/travis/build/apache/zeppelin/zeppelin-server/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :zeppelin-server

Seems not irrelevant with this change :)

@AhyoungRyu
Copy link
Contributor Author

Merging this if there are no more discussions

@corneadoug
Copy link
Contributor

Go for it

@asfgit asfgit closed this in de2d6e4 Oct 6, 2016
asfgit pushed a commit that referenced this pull request Oct 11, 2016
### What is this PR for?
Last profile of CI test fails after #1461. This PR fixes it.
```
Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 110.883 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT
testWidth(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 20.055 sec  <<< FAILURE!
java.lang.AssertionError: New Width is : 4
Expected: <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
	at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)

testWidth(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 20.056 sec  <<< FAILURE!
java.lang.AssertionError: New Width is : 8
Expected: <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
	at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)
```
### What type of PR is it?
Test fix

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Mina Lee <minalee@apache.org>

Closes #1504 from minahlee/fix/testWidth and squashes the following commits:

410bb55 [Mina Lee] Fix testWidth selnium test
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
Just rearranged the placement of Zeppelin logo, title and text in "About Zeppelin". In the mobile screen as well.

### What type of PR is it?
Improvement

### What is the Jira issue?
No Jira issue for this

### How should this be tested?
To check this change in your local, build only `zeppelin-web` with `./grunt build` and then browse with `./grunt serve`.

### Screenshots (if appropriate)
- **Before**
  1. desktop & tablet screen
<img src="https://cloud.githubusercontent.com/assets/10060731/18860571/8aa85aec-84b9-11e6-9112-b6869291f8f0.png" width="500px">

  2. mobile screen
<img src="https://cloud.githubusercontent.com/assets/10060731/18860576/91f623a6-84b9-11e6-96ba-e34c43221143.png" width="300px">

- **After**
  1. desktop & tablet screen
<img src="https://cloud.githubusercontent.com/assets/10060731/19140869/b5ab79e0-8bcb-11e6-946f-df63045e6f1e.png" width="500px">

  2. mobile screen
<img src="https://cloud.githubusercontent.com/assets/10060731/19140879/c034b476-8bcb-11e6-977b-29deb6776f13.png" width="300px">

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <ahyoungryu@apache.org>

Closes apache#1461 from AhyoungRyu/improve/aboutZeppelin and squashes the following commits:

16421c9 [AhyoungRyu] Add a newline
a8628c8 [AhyoungRyu] Apply responsive design
81ef021 [AhyoungRyu] Rearrange 'About Zeppelin'
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
Last profile of CI test fails after apache#1461. This PR fixes it.
```
Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 110.883 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT
testWidth(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 20.055 sec  <<< FAILURE!
java.lang.AssertionError: New Width is : 4
Expected: <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
	at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)

testWidth(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 20.056 sec  <<< FAILURE!
java.lang.AssertionError: New Width is : 8
Expected: <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
	at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314)
```
### What type of PR is it?
Test fix

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Mina Lee <minalee@apache.org>

Closes apache#1504 from minahlee/fix/testWidth and squashes the following commits:

410bb55 [Mina Lee] Fix testWidth selnium test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants