-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Rearrange the contents in "About Zeppelin" #1461
Conversation
would |
@felixcheung AFAIK since this |
Hmmm I don't think anyone has reported this being an issue so I think we are good. |
One CI test is failed in
and seems irrelevant with this change. |
@AhyoungRyu Tested, LGTM! |
93ad0c6
to
804d8bb
Compare
@corneadoug Thanks! I retriggered CI just for sure. After checking CI then will merge this :) |
@AhyoungRyu Rebasing from master should fix the CI issue |
804d8bb
to
16421c9
Compare
@corneadoug rebased but it still failed in Selenium test. The error log is like below
Seems not irrelevant with this change :) |
Merging this if there are no more discussions |
Go for it |
### What is this PR for? Last profile of CI test fails after #1461. This PR fixes it. ``` Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 110.883 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 20.055 sec <<< FAILURE! java.lang.AssertionError: New Width is : 4 Expected: <true> but: was <false> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65) at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78) at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63) at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314) testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 20.056 sec <<< FAILURE! java.lang.AssertionError: New Width is : 8 Expected: <true> but: was <false> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65) at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78) at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63) at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314) ``` ### What type of PR is it? Test fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes #1504 from minahlee/fix/testWidth and squashes the following commits: 410bb55 [Mina Lee] Fix testWidth selnium test
### What is this PR for? Just rearranged the placement of Zeppelin logo, title and text in "About Zeppelin". In the mobile screen as well. ### What type of PR is it? Improvement ### What is the Jira issue? No Jira issue for this ### How should this be tested? To check this change in your local, build only `zeppelin-web` with `./grunt build` and then browse with `./grunt serve`. ### Screenshots (if appropriate) - **Before** 1. desktop & tablet screen <img src="https://cloud.githubusercontent.com/assets/10060731/18860571/8aa85aec-84b9-11e6-9112-b6869291f8f0.png" width="500px"> 2. mobile screen <img src="https://cloud.githubusercontent.com/assets/10060731/18860576/91f623a6-84b9-11e6-96ba-e34c43221143.png" width="300px"> - **After** 1. desktop & tablet screen <img src="https://cloud.githubusercontent.com/assets/10060731/19140869/b5ab79e0-8bcb-11e6-946f-df63045e6f1e.png" width="500px"> 2. mobile screen <img src="https://cloud.githubusercontent.com/assets/10060731/19140879/c034b476-8bcb-11e6-977b-29deb6776f13.png" width="300px"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <ahyoungryu@apache.org> Closes apache#1461 from AhyoungRyu/improve/aboutZeppelin and squashes the following commits: 16421c9 [AhyoungRyu] Add a newline a8628c8 [AhyoungRyu] Apply responsive design 81ef021 [AhyoungRyu] Rearrange 'About Zeppelin'
### What is this PR for? Last profile of CI test fails after apache#1461. This PR fixes it. ``` Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 110.883 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 20.055 sec <<< FAILURE! java.lang.AssertionError: New Width is : 4 Expected: <true> but: was <false> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65) at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78) at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63) at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314) testWidth(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 20.056 sec <<< FAILURE! java.lang.AssertionError: New Width is : 8 Expected: <true> but: was <false> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65) at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78) at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63) at org.apache.zeppelin.integration.ParagraphActionsIT.testWidth(ParagraphActionsIT.java:314) ``` ### What type of PR is it? Test fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes apache#1504 from minahlee/fix/testWidth and squashes the following commits: 410bb55 [Mina Lee] Fix testWidth selnium test
What is this PR for?
Just rearranged the placement of Zeppelin logo, title and text in "About Zeppelin". In the mobile screen as well.
What type of PR is it?
Improvement
What is the Jira issue?
No Jira issue for this
How should this be tested?
To check this change in your local, build only
zeppelin-web
with./grunt build
and then browse with./grunt serve
.Screenshots (if appropriate)
Questions: