ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be managed seperately #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new property for ssl port
|
Travis failure is unrelated and only on one of the build profile |
|
Shell we have an entry for this change in upgrading section? |
|
@Leemoonsoo sure. will update. |
|
Tested on local, LGTM. |
|
LGTM |
|
cool. will merge this if there are no more discussions |
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Use a different variable for ssl port number - add new property for ssl port ### What type of PR is it? Improvement ### Todos * [x] - Add documentation in upgrade.md ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1321 ### How should this be tested? Add ZEPPELIN_SSL_PORT or zeppelin.server.ssl.port in zeppelin env or site xml and configure the rest of ssl properties and start zeppelin. ### Screenshots (if appropriate) n/a ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? Updated install doc Author: Renjith Kamath <renjith.kamath@gmail.com> Closes apache#1489 from r-kamath/ZEPPELIN-1321 and squashes the following commits: 8f9006a [Renjith Kamath] ZEPPELIN-1321 update zeppelin upgrade guide 41899b1 [Renjith Kamath] ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be managed seperately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Use a different variable for ssl port number
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1321
How should this be tested?
Add ZEPPELIN_SSL_PORT or zeppelin.server.ssl.port in zeppelin env or site xml and configure the rest of ssl properties and start zeppelin.
Screenshots (if appropriate)
n/a
Questions: