Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-451] Save codes and messages as multi-line #1494

Closed
wants to merge 3 commits into from

Conversation

sixmen
Copy link
Contributor

@sixmen sixmen commented Oct 7, 2016

What is this PR for?

Save Paragraph texts and result msgs as array of strings instead of one long string.
One long strings are not VCS-friendly.

What type of PR is it?

Improvement

What is the Jira issue?

How should this be tested?

Modify notebooks and check saved note files

Screenshots (if appropriate)

2016-10-07 11 53 28

2016-10-07 11 53 44

### Questions: - Does the licenses files need update? NO - Is there breaking changes for older versions? Notebooks from new zeppelin can not be imported in old zeppelin. - Does this needs documentation? NO

@anthonycorbacho
Copy link
Contributor

@sixmen thank you for your contribution, this feature looks AWESOME.
I didnt dive into the code, but one question came in my mind;

This change is kinda breaking change since the notebook format is now different from what we have. So what can be the best way in your opinion to support old notebook format?

@sixmen
Copy link
Contributor Author

sixmen commented Oct 10, 2016

It supports old notebook format.
Old code can not read new notebook format, but it can not be helped any way.
So I think it is an endurable breaking change.

@sixmen
Copy link
Contributor Author

sixmen commented Dec 27, 2016

I worked again for this commit with recent sources.
I hope someone reviews this pull request.
As I know, there are already breaking changes in the notebook format. So it does not matter with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants