[Zeppelin-1540] fix note url input placeholder #1509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khalidhuseynov nice catch! yeah it's really confusing. Looks good 👍 |
|
LGTM! |
|
LGTM. Merge if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Oct 17, 2016
Fix input form placeholder for `note url` Improvement * [x] - Task [ZEPPELIN-1540](https://issues.apache.org/jira/browse/ZEPPELIN-1540) go to import note menu -> add from url -> see input forms Before: <img width="593" alt="screen shot 2016-10-13 at 2 37 24 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337731/9ea41248-9152-11e6-859b-757f44b2866a.png"> After: <img width="601" alt="screen shot 2016-10-13 at 2 36 06 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337716/7f90522c-9152-11e6-8ad2-cbfcdc241e10.png"> * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closes #1509 from khalidhuseynov/fix/note-import-placeholder and squashes the following commits: c01b982 [Khalid Huseynov] note name -> note url (cherry picked from commit 3afd444) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: zeppelin-web/src/components/noteName-import/note-import-dialog.html
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Fix input form placeholder for `note url` ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? [ZEPPELIN-1540](https://issues.apache.org/jira/browse/ZEPPELIN-1540) ### How should this be tested? go to import note menu -> add from url -> see input forms ### Screenshots (if appropriate) Before: <img width="593" alt="screen shot 2016-10-13 at 2 37 24 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337731/9ea41248-9152-11e6-859b-757f44b2866a.png"> After: <img width="601" alt="screen shot 2016-10-13 at 2 36 06 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337716/7f90522c-9152-11e6-8ad2-cbfcdc241e10.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closes apache#1509 from khalidhuseynov/fix/note-import-placeholder and squashes the following commits: c01b982 [Khalid Huseynov] note name -> note url
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Fix input form placeholder for `note url` ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? [ZEPPELIN-1540](https://issues.apache.org/jira/browse/ZEPPELIN-1540) ### How should this be tested? go to import note menu -> add from url -> see input forms ### Screenshots (if appropriate) Before: <img width="593" alt="screen shot 2016-10-13 at 2 37 24 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337731/9ea41248-9152-11e6-859b-757f44b2866a.png"> After: <img width="601" alt="screen shot 2016-10-13 at 2 36 06 pm" src="https://cloud.githubusercontent.com/assets/1642088/19337716/7f90522c-9152-11e6-8ad2-cbfcdc241e10.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Closes apache#1509 from khalidhuseynov/fix/note-import-placeholder and squashes the following commits: c01b982 [Khalid Huseynov] note name -> note url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix input form placeholder for
note urlWhat type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-1540
How should this be tested?
go to import note menu -> add from url -> see input forms
Screenshots (if appropriate)
Before:
After:
Questions: