-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop #1575
Conversation
@prabhjyotsingh @felixcheung Please help review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me, we need to merge this badboy asap since other tests are failing :(
Rebase is coming brothers of the night
@@ -41,6 +41,8 @@ | |||
<assertj.version>1.7.0</assertj.version> | |||
<mockito.version>1.9.5</mockito.version> | |||
<livy.version>0.2.0</livy.version> | |||
<spark.version>1.5.2</spark.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought livy defaults to spark 1.6.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
livy 0.2 use spark 1.5 by default. https://github.com/cloudera/livy/blob/branch-0.2/pom.xml
LGTM. I will merge it as hotfix if there is no more comment. |
@minahlee yes please merge it asap this a total war zone here |
### What is this PR for? I see several times of travis failure due to downloading cdh spark/hadoop for livy interpreter. This may be due to cdh repository issue, so in this PR I change it to apache spark/hadoop. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1597 ### How should this be tested? No test added ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#1575 from zjffdu/ZEPPELIN-1597 and squashes the following commits: 5077f20 [Jeff Zhang] ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop
### What is this PR for? I see several times of travis failure due to downloading cdh spark/hadoop for livy interpreter. This may be due to cdh repository issue, so in this PR I change it to apache spark/hadoop. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1597 ### How should this be tested? No test added ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#1575 from zjffdu/ZEPPELIN-1597 and squashes the following commits: 5077f20 [Jeff Zhang] ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop
What is this PR for?
I see several times of travis failure due to downloading cdh spark/hadoop for livy interpreter. This may be due to cdh repository issue, so in this PR I change it to apache spark/hadoop.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
No test added
Questions: