New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEPPELIN-415 document for Apache Kylin Interpreter #1576
Conversation
LGTM |
@janzhongi Thanks for your contribution.
You can just copy & paste the above table if you want. I added some markdown escaping for |
|
||
## Overview | ||
[Apache Kylin](https://kylin.apache.org/) is an open source Distributed Analytics Engine designed to provide SQL interface and multi-dimensional analysis (OLAP) on Hadoop supporting extremely large datasets, original contributed from eBay Inc. The interpreter assumes that Apache Kylin has been installed and you can connect to Apache Kylin from the machine Apache Zeppelin is installed. | ||
To get start with Apache Kylin, please see [Apache Kylin Quickstart](https://kylin.apache.org/docs15/index.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janzhongi 15 in docs15
is the version of Kylin, right? If so, do we need to set the version in this link?
Seems https://kylin.apache.org/latest/index.html
doesn't work... What do you think? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AhyoungRyu Thank you for your review, for 'doc15' you mentioned, now 'doc15' is a stable link for kylin, we do not have other link like 'latest' now, if there's update on this in future, I will also update on Zeppelin side.
And for 'Default Value', if you check again you can see first column represents property name, and sceond column represents default value,is that what you mean? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janzhongi I see. Thanks for the explanation.
Currently the second column is the "description" for the property name, not "default value". I mean we need three column "Property name", "Default value" and "Description".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, thank you for you reminding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated code as your suggestion, thank you 👍
@janzhongi Thanks for your prompt update! Changes are looks good to me. |
This is document for Apache Kylin Interpreter for Apache Zeppelin Documentation Done https://issues.apache.org/jira/browse/ZEPPELIN-415 * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? This is document Author: zhongjian <jiatuer@163.com> Author: Jason <jiatuer@163.com> Closes apache#1576 from janzhongi/master and squashes the following commits: 5464006 [zhongjian] add default value for kylin query api config c26fa77 [Jason] ZEPPELIN-415 document for Apache Kylin Interpreter
What is this PR for?
This is document for Apache Kylin Interpreter for Apache Zeppelin
What type of PR is it?
Documentation
Todos
Done
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-415
How should this be tested?
Screenshots (if appropriate)
Questions:
No
No
This is document