[MINOR] Turn on authenticaiton in shiro.ini.template by default #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Yeah it makes sense. LGTM |
|
Nice! LGTM! |
|
LGTM |
|
Good catch! |
|
merging if no more discussion ? |
|
I thought Zeppelin does not read conf/shiro.ini.template, but it actually does. Should i revert it? or #1595 will bring default behavior back? @anthonycorbacho @minahlee @prabhjyotsingh |
|
#1595 will fix this issue |
|
Since #1595 will fix the issue let's test it out quickly, and merge it. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Nov 4, 2016
### What is this PR for? apache#1568 moved conf/shiro.ini to conf/shiro.ini.template. Now i think it make sense to turn authentication on by default in conf/shiro.ini.template. ### What type of PR is it? Improvement ### Todos * [x] - Turn authentication on by default in the template ### What is the Jira issue? related to issues.apache.org/jira/browse/ZEPPELIN-1590 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1583 from Leemoonsoo/turn_on_authc and squashes the following commits: 7976e7e [Lee moon soo] Turn on authenticaiton in shiro.ini.template by default
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Nov 4, 2016
### What is this PR for? apache#1568 moved conf/shiro.ini to conf/shiro.ini.template. Now i think it make sense to turn authentication on by default in conf/shiro.ini.template. ### What type of PR is it? Improvement ### Todos * [x] - Turn authentication on by default in the template ### What is the Jira issue? related to issues.apache.org/jira/browse/ZEPPELIN-1590 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1583 from Leemoonsoo/turn_on_authc and squashes the following commits: 7976e7e [Lee moon soo] Turn on authenticaiton in shiro.ini.template by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
#1568 moved conf/shiro.ini to conf/shiro.ini.template.
Now i think it make sense to turn authentication on by default in conf/shiro.ini.template.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
related to issues.apache.org/jira/browse/ZEPPELIN-1590
Questions: