[ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy user handling #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthonycorbacho thanks for enhancements! i started looking into this one and first of all CI looks like failing with checkstyle issues. Also some methods seem to be missing, and proper jira ticket would be appreciated :) let me know if i can help somehow |
|
@khalidhuseynov as you can see its a wip, i will let you know when its ready for review |
- Now takes a token on every http request
anthonycorbacho
changed the title
anthonycorbacho
changed the title
| @@ -157,6 +161,9 @@ protected User authenticateUser(String requestBody) { | |||
| ZeppelinServer.notebookWsServer.broadcastReloadedNoteList( | |||
| new org.apache.zeppelin.user.AuthenticationInfo(account.login), userAndRoles); | |||
|
|
|||
| // Add ZeppelinHub user_session token this singleton map, this will help ZeppelinHubRepo | |||
| // to get specific information about the current user. | |||
| UserSessionContainer.instance.setSession(account.login, userSession); | |||
There was a problem hiding this comment.
i think this setSession should go few lines above, right after catch statement, since there's broadcastReloadedNoteList called afterwards that will require
|
CI is green, please review otherwise merging it :) |
|
thanks for the fix, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR bring multi user handling to ZeppelinHubNotebookRepo.
What type of PR is it?
[Improvement ]
What is the Jira issue?
Questions: