[DOCS] Update Shiro configuration file with new package names #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, merging to master as a hotfix based on user feedback in this thread, if there is no further discussion. |
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2016
### What is this PR for? Based on #1700, https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#groups-and-permissions-optional needs be updated accordingly. ``` activeDirectoryRealm = org.apache.zeppelin.server.ActiveDirectoryGroupRealm ldapRealm = org.apache.zeppelin.server.LdapGroupRealm ``` to ``` ldapRealm = org.apache.zeppelin.realm.LdapGroupRealm ldapRealm = org.apache.zeppelin.realm.LdapGroupRealm ``` ### What type of PR is it? Documentation ### What is the Jira issue? N/A ### How should this be tested? No need to test this I guess. I just changed 3 words :D ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes #1703 from AhyoungRyu/update/shiro-config-docs and squashes the following commits: 8159131 [AhyoungRyu] Update Shiro conf file with new package names in docs accordinly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Since most of authentication related realm classes has moved from
org.apache.zeppelin.serverpackage intoorg.apache.zeppelin.realm, we need to update correspondingshiro.ini.templatefileWhat type of PR is it?
Improvement | Documentation
Todos
What is the Jira issue?
N/A
How should this be tested?
same as for testing
LdapGroupRealmorActiveDirectoryGroupRealmScreenshots (if appropriate)
Questions: