Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOT FIX] Fix broken display_formula.png by using relative path #1752

Closed
wants to merge 1 commit into from

Conversation

AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Dec 13, 2016

What is this PR for?

Currently display_formula.png (added by #1606) is broken in here: http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/displaysystem/basicdisplaysystem.html#mathematical-expressions

Fixed it by using relative path for the image. But have no idea why the other image files are not broken in that page.

What type of PR is it?

Documentation | Hot Fix

Todos

  • - Task

What is the Jira issue?

N/A

How should this be tested?

It can't be reproduced using docs dev mode. Needs to be tested with below steps.

1) build gh-pages (website) branch
JEKYLL_ENV=production bundle exec jekyll build
cp -r _site/ /tmp/zeppelin_website/
mkdir -p /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT

2) build this patch (docs) and copy it under docs/0.7.0-SNAPSHOT of website
cd docs
bundle exec jekyll build --safe
cp -r _site/ /tmp/zeppelin_website/0.7.0-SNAPSHOT/

3) start httpserver and browse http://localhost:8000/docs/0.7.0-SNAPSHOT/
cd /tmp/zeppelin_website
python -m SimpleHTTPServer

Screenshots (if appropriate)

Before

  • In the official website

screen shot 2016-12-13 at 7 07 27 pm

GET http://zeppelin.apache.org/assets/themes/zeppelin/img/screenshots/display_formula.png 404 (Not Found)

After

  • test locally using same with production path

screen shot 2016-12-13 at 7 09 42 pm

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@AhyoungRyu AhyoungRyu closed this Dec 13, 2016
@AhyoungRyu AhyoungRyu reopened this Dec 13, 2016
@astroshim
Copy link
Contributor

LGTM!!

@Leemoonsoo
Copy link
Member

LGTM.
Merge it as a hotfix.

@asfgit asfgit closed this in 641a641 Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants