Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteMenu') calls #1770

Closed
wants to merge 2 commits into from

Conversation

cuspymd
Copy link
Contributor

@cuspymd cuspymd commented Dec 15, 2016

What is this PR for?

It's to fix the issue 'ZEPPELIN-1763' (Zeppelin hangs if I repeatedly select and deselect note name).
When the note name was changed, there was a problem that the 'setNoteName' listener was registered in duplicate and occupied resources.
To fix it, I moved the function that registers the listener out of initNoteBook()

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

ZEPPELIN-1763

How should this be tested?

Repeat changing note name.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

The listners are added in duplicate on $scope.$on('setNoteMenu') calls.

The listners are added in duplicate on $scope.$on('setNoteMenu') calls.
@Leemoonsoo
Copy link
Member

Thanks for the contribution.

I'm getting build error on zeppelin-web module

[INFO] Running "jscs:test" (jscs) task
[INFO] disallowMultipleLineBreaks: ; and it should have at most 2 line(s) between them at test/spec/controllers/notebook.js :
[INFO]    100 |    scope.killSaveTimer();
[INFO]    101 |    expect(scope.saveTimer).toEqual(null);
[INFO]    102 |  });
[INFO] -------------^
[INFO]    103 |
[INFO]    104 |
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:test" failed. Use --force to continue.
[INFO] 
[INFO] Aborted due to warnings.

Could you check?

@cuspymd
Copy link
Contributor Author

cuspymd commented Dec 16, 2016

@Leemoonsoo Modified
Thanks.

@Leemoonsoo
Copy link
Member

A test profile failure looks not related. (https://issues.apache.org/jira/browse/ZEPPELIN-1830)
LGTM and merge to master if there're no further comments.

@asfgit asfgit closed this in 9eb580c Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants