[DOCS] Add doc about zeppelin.notebook.public #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AhyoungRyu Please help review |
|
Push another commit to fix the double checking lock for singleton |
|
LGTM |
|
Looks good :) |
|
@zjffdu All CI build jobs are red now. Could you check again? |
felixcheung
reviewed
Dec 18, 2016
| @@ -65,7 +65,7 @@ | |||
|
|
|||
| private NotebookAuthorization() {} | |||
|
|
|||
| public static NotebookAuthorization init(ZeppelinConfiguration config) { | |||
| public static synchronized NotebookAuthorization init(ZeppelinConfiguration config) { | |||
There was a problem hiding this comment.
for a change like this perhaps it's better to have a JIRA to track change?
There was a problem hiding this comment.
Thanks @felixcheung & @AhyoungRyu I have reverted and will do it in another ticket.
|
@zjffdu Do you have any chances to look into the last comment by @felixcheung ? |
This reverts commit 92472f9.
|
Looks good! Thanks @zjffdu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add document about zeppelin.notebook.public
What type of PR is it?
[Documentation]
What is the Jira issue?
Questions: