Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1845] InterpreterFactory.createOrGetInterpreterList fails when interpreter mode is "perUser": "scoped" #1790

Closed
wants to merge 1 commit into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

When trying to add a paragraph, whose default interpreter is running in mode "perUser": "scoped" fails with following exception

ERROR [2016-12-22 11:52:18,784] ({qtp112466394-59} NotebookServer.java[onMessage]:318) - Can't handle message
java.lang.NullPointerException
	at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
	at java.util.concurrent.ConcurrentHashMap.containsKey(ConcurrentHashMap.java:964)
	at org.apache.zeppelin.interpreter.InterpreterFactory.createOrGetInterpreterList(InterpreterFactory.java:1219)
	at org.apache.zeppelin.interpreter.InterpreterFactory.getInterpreter(InterpreterFactory.java:1333)
	at org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:598)
	at org.apache.zeppelin.notebook.Paragraph.getMagic(Paragraph.java:587)
	at org.apache.zeppelin.notebook.Note.setParagraphMagic(Note.java:506)
	at org.apache.zeppelin.notebook.Note.insertParagraph(Note.java:316)
	at org.apache.zeppelin.socket.NotebookServer.insertParagraph(NotebookServer.java:1330)
	at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:241)
	at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
	at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
	at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
	at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
	at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
	at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
	at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
	at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
	at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
	at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
	at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
	at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
	at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
	at java.lang.Thread.run(Thread.java:745)

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

Outline the steps to test the PR here.

Screenshots (if appropriate)

Before:
before

After:
after

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@prabhjyotsingh prabhjyotsingh changed the title InterpreterFactory.createOrGetInterpreterList fails when interpreter mode is "perUser": "scoped" [ZEPPELIN-1845] InterpreterFactory.createOrGetInterpreterList fails when interpreter mode is "perUser": "scoped" Dec 22, 2016
@prabhjyotsingh
Copy link
Contributor Author

CI Green, ready for review.

@r-kamath
Copy link
Member

LGTM

@prabhjyotsingh
Copy link
Contributor Author

Merging this if no more discussion.

@asfgit asfgit closed this in 9e75f5b Dec 28, 2016
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-1845 branch February 25, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants