Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1868]fix to not shows up the login button on Anonymous mode. #1813

Closed
wants to merge 1 commit into from

Conversation

astroshim
Copy link
Contributor

What is this PR for?

This PR fixs to not shows up the login button on Anonymous mode.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1868

How should this be tested?

  1. Give permission on note.
  2. Turn off the shiro.
  3. Delete note that you made on 1.
  4. Then you can see the login button like as screen shot.

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor

Yeah it makes sense. Tested and it's working well 👍

@soralee
Copy link
Contributor

soralee commented Dec 30, 2016

@astroshim It's great work! I will test it!

But, I would like to suggest one thing.
According to what I understand, your screenshot and Then you can see the login button like as screen shot. describes the content before fixing bug in this PR description, right?

I think in this part, It makes confusing for your description of PR. (AFAIK, In general, the description of the PR describes the content after the bug has been fixed.)

So, it would be clear if there is content after fixing the bug 😃
What do you think?

@soralee
Copy link
Contributor

soralee commented Dec 30, 2016

Tested and It works as expected like below!!

[Before]
z_1813_b

[After]
z_1813_a

@astroshim
Copy link
Contributor Author

@soralee Thank you for reviewing and commenting!!

@AhyoungRyu
Copy link
Contributor

LGTM. Merge if there are no more comments

@asfgit asfgit closed this in b7ffb06 Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants