Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Fix broken CSS for plain text paragraph result #1816

Closed
wants to merge 1 commit into from

Conversation

AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Dec 29, 2016

What is this PR for?

After #1711 merged, plain text paragraph result CSS is broken now. Originally the text result like below (it's 0.6.2). The font was Monaco applied by .paragraph .text class.
result1
screen shot 2016-12-29 at 2 58 14 pm

But now bootstrap default font Helvetica is used.
result2
screen shot 2016-12-29 at 2 58 07 pm

So I bring it back by adding new class .plainTextContainer.

What type of PR is it?

Bug Fix

What is the Jira issue?

No Jira issue for this

How should this be tested?

  1. See the current text paragraph result (e.g. Zeppelin tutorial: Spark)
  2. Apply this patch and start dev mode under zeppelin-web \w npm run dev -> browse http://localhost:9000
  3. Compare the text paragraph result

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@soralee
Copy link
Contributor

soralee commented Dec 30, 2016

@AhyoungRyu What a nice catch!
Tested and It works very well 👍

[Before]
z1816_b

[After]
z1816_a

@AhyoungRyu
Copy link
Contributor Author

AhyoungRyu commented Dec 30, 2016

@soralee Thanks for testing it out!

@AhyoungRyu
Copy link
Contributor Author

Merge if there are no more comments on this

@asfgit asfgit closed this in ae35ec3 Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants