[DOCS] Remove outdated 'Security Setup' section in SECURITY-README #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
felixcheung
reviewed
Jan 3, 2017
| 3. Start Zeppelin : bin/zeppelin.sh | ||
| 4. point your browser to http://localhost:8080 | ||
| 5. Login using one of the user/password combinations defined in the conf/shiro.ini file. | ||
| Please check [Shiro authentication in Apache Zeppelin](https://zeppelin.apache.org/docs/snapshot/security/shiroauthentication.html) in our official website for more detailed information(e.g. How to setup the security, How to configure user groups and permissions, and etc). |
There was a problem hiding this comment.
instead of https://zeppelin.apache.org/docs/snapshot
point to https://zeppelin.apache.org/docs/latest
?
There was a problem hiding this comment.
@felixcheung Not sure but, I thought that the readers who will refer this SECURITY-README.md are commonly visiting Zeppelin github repo(it's snapshot version) not Zeppelin itself. So like Zeppelin README.md(you can see "install" and "Build from source" are linked \w snapshot) does, I put snapshot link in here. What do you think? :)
|
Hmm, true, it's possible that way.
I just thought its better to point to the latest release, but I can see your point here.
I don't feel strongly either case, so LGTM.
|
|
@felixcheung Yeah I know what you mean. Thanks for your suggestion and review anyway! (CI failure is not relevant with this issue. Docs doesn't have any tests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
SECURITY-README.md was added by #53 when Shiro auth was implemented for the first time. But I think we need to keep "Security Setup" information in one source; Official docs website and guide ppl to see this official docs page so that
SECURITY-README.mdcan only contain dev related contents (not step by step setup guide).What type of PR is it?
Documentation
What is the Jira issue?
N/A
How should this be tested?
Just clicking "View" would be enough I guess :)
Questions: