Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-1901. Output schema might be null for PigQueryInterpreter #1837

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jan 4, 2017

What is this PR for?

The output schema might be null if user doesn't specify it explicitly. In this PR, I will use 'col_{pos}' to replace the column name if it is null.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Unit test is added.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Jan 4, 2017

@felixcheung Please help review, I will add document in #1830 to encourage user to specify schema explicitly.

@zjffdu zjffdu closed this Jan 4, 2017
@zjffdu zjffdu reopened this Jan 4, 2017
@zjffdu
Copy link
Contributor Author

zjffdu commented Jan 6, 2017

Ping @felixcheung , CI failure is not relevant.

AngularElem
- should provide onclick method *** FAILED ***
  The code passed to eventually never returned normally. Attempted 1 times over 192.484891 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)

@felixcheung
Copy link
Member

LGTM
merging if no more comment

@asfgit asfgit closed this in a6d01aa Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants