Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-451] Save codes and messages as multi-line #1893

Closed
wants to merge 3 commits into from

Conversation

sixmen
Copy link
Contributor

@sixmen sixmen commented Jan 12, 2017

What is this PR for?

Save Paragraph texts and result msgs as array of strings instead of one long string.
One long strings are not VCS-friendly.

What type of PR is it?

Improvement

What is the Jira issue?

How should this be tested?

Modify notebooks and check saved note files

Screenshots (if appropriate)

2017-01-12 6 09 23

2017-01-12 6 09 40

Questions:

  • Does the licenses files need update? NO
  • Is there breaking changes for older versions? Notebooks from new zeppelin can not be imported in old zeppelin.
  • Does this needs documentation? NO

@Leemoonsoo
Copy link
Member

@sixmen Thanks for the contribution.
I tested this branch and it works well.

While this makes incompatible changes (previous version of Zeppelin can't load the notebook), i'd like to ask more people review this PR, will there be any type of side effects.

@soralee
Copy link
Contributor

soralee commented Jan 25, 2017

Thank @sixmen for improving this. It's very good feature!

but I think sudden changes, part of importing notebook, will make users uncomfortable.
In my opinion, both old version notebook and now version notebook should be nice if it is compatible.

@sixmen
Copy link
Contributor Author

sixmen commented Jan 31, 2017

@soralee You mean, it is good if users of old Zeppelin can import new version notebooks?

I think forward compatibility is unnecessary, but if you tell me a solution that you want, I'll try to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants